FINERACT-2245: Mix Taxonomy (org.apache.fineract.mix)#4635
Closed
oleksma wants to merge 1 commit intoapache:developfrom
Closed
FINERACT-2245: Mix Taxonomy (org.apache.fineract.mix)#4635oleksma wants to merge 1 commit intoapache:developfrom
oleksma wants to merge 1 commit intoapache:developfrom
Conversation
...vider/src/main/java/org/apache/fineract/mix/handler/UpdateTaxonomyMappingCommandHandler.java
Show resolved
Hide resolved
| return new MixTaxonomyMappingResponse(result.getIdentifier(), result.getConfig()); | ||
| } catch (final JpaSystemException | DataIntegrityViolationException dve) { | ||
| return CommandProcessingResult.empty(); | ||
| return new MixTaxonomyMappingResponse(null, null); |
Contributor
There was a problem hiding this comment.
What about create just like new MixTaxonomyMappingResponse() ?
oleksma
force-pushed
the
FINERACT-2169/subtask-FINERACT-2245-Mix-Taxonomy-(org.apache.fineract.mix)
branch
2 times, most recently
from
b2a5d32 to
2b18982
Compare
oleksma
force-pushed
the
FINERACT-2169/subtask-FINERACT-2245-Mix-Taxonomy-(org.apache.fineract.mix)
branch
from
2b18982 to
714f1a7
Compare
oleksma
force-pushed
the
FINERACT-2169/subtask-FINERACT-2245-Mix-Taxonomy-(org.apache.fineract.mix)
branch
from
714f1a7 to
5aedd89
Compare
Contributor
|
@oleksma @VictorPavfurious @vidakovic what's up with this? |
Contributor
|
@oleksma , do you have some blockers ? |
Contributor
Author
|
I will review it, it has been returned to status DRAFT PR |
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring done:
Applied approach "New command processing"
Renamed *Data to *Response
Applied Lombok
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.